Repository navigation
Conversation
….lib links on MSVC The MSVC branch only knows dllexport (MICROTEX_LIBRARY defined) and dllimport (not defined): consumers of a static microtex.lib see dllimport and fail to link (unresolved __imp_* symbols, e.g. __imp_??0Stroke@microtex@@qeaa@XZ). With MICROTEX_STATIC defined, MICROTEX_EXPORT is empty.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MSVC branch in microtexexport.h only knows two states:
There is no static-library branch. Static-lib consumers see
__declspec(dllimport)and emit__imp_*references that cannot be resolved against the static microtex.lib (which only contains plain symbols, no _imp stubs).This PR adds a third branch: when MICROTEX_STATIC is defined, expand MICROTEX_EXPORT to nothing.