Conversation
When building with Clang 23+, `test_any_sender.cpp` fails to compile
because one of the test cases instatiates a deprecated class template
(`exec::any_receiver_ref`) inside `std::is_constructible_v`. For some
reason, the file-wide `-Wno-deprecated-declarations` pragma doesn't
suppress the warning, perhaps because the instantiation of the
deprecated class template happens inside the standard library.
The error looks like this:
```
error:
'any_receiver_ref<std::execution::completion_signatures<std::execution::set_value_t ()>>'
is deprecated: use exec::any_receiver<Sigs, ReceiverQueries> instead
[-Werror,-Wdeprecated-declarations]
27 | ... inline constexpr bool is_constructible_v = __is_constructible(_Tp, _Args...);
| ^
```
This diff suppresses the warning by forcing the first class template
instantiation to be inside the blanket suppression (with an
otherwise-useless `static_assert(sizeof(type) != 0)`) so that the
subsequent use of `std::is_constructible_v` doesn't re-trigger the
warning.
ericniebler
approved these changes
Oct 3, 2026
Collaborator
|
/ok to test ce19cb2 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building with Clang 23+,
test_any_sender.cppfails to compile because one of the test cases instantiates a deprecated class template (exec::any_receiver_ref) insidestd::is_constructible_v. For some reason, the file-wide-Wno-deprecated-declarationspragma doesn't suppress the warning, perhaps because the instantiation of the deprecated class template happens inside the standard library.The error looks like this:
This diff suppresses the warning by forcing the first class template instantiation to be inside the blanket suppression (with an otherwise-useless
static_assert(sizeof(type) != 0)) so that the subsequent use ofstd::is_constructible_vdoesn't re-trigger the warning.