Repository navigation
fix(pe3): keep credential actions visible in skill-card fields - #895
Open
yashrajp22 wants to merge 5 commits into
Open
yashrajp22 wants to merge 5 commits into
yashrajp22 wants to merge 5 commits into
Conversation
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #827. A skill-card field such as
Credential Type(s): [Read Perforce access credentials]could hide a real credential-access finding. Keep the original fix for harmless credential disclosures, while retaining findings for credential reads, acquisition, storage and transfer instructions inside the field.The new guard stays within the existing 4,096-character field limit and leaves the shared OAuth checks unchanged. Exact adjective compounds such as
read-onlyandopen-sourceremain harmless before or after credential, secret and token nouns; actual actions and sensitive paths still remain visible.Validation:
All scan checks used offline static analysis; no live-provider behavior is changed or claimed.