Repository navigation
fix(lint): pin Node for pre-commit hooks - #36
Merged
Thomas A Caswell (tacaswell) merged 1 commit intoNov 3, 2026
Merged
Conversation
nodeenv resolves unpinned Node to the 27.0.0-alpha.0.0.0 pre-release, which it cannot parse, so the markdownlint environment fails to build. Assisted-by: opencode:claude-sonnet-5-5
There was a problem hiding this comment.
🔵 Needs a closer look
CI must confirm Node 26.13.0 availability and successful markdownlint environment creation with prek, since neither could be verified in the offline source-only review.
No open issues 🎉
What changed in this PR
Pins Node for pre-commit’s Node-based hooks to avoid hook environment build failures caused by nodeenv selecting an unparseable prerelease.
Changes:
- Sets
default_language_version.nodeto26.13.0. - Documents the pin’s purpose and the intent to match the Node major version in
pixi.toml.
| File | Description |
|---|---|
.pre-commit-config.yaml |
Adds a default Node version pin and explanatory comments for Node-based hooks such as markdownlint. |
Review effort: Balanced
Contributor
|
The floor for the fixed trust store is 26.12.1 so this is fine. |
Thomas A Caswell (tacaswell)
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
markdownlint's hook environment fails to build, locally and in CI.
pre-commit ignores pixi's Node and falls back to nodeenv, which installs
the newest release on nodejs.org. Since 2026-10-29 that is
27.0.0-alpha.0.0.0, which nodeenv cannot parse.default_language_version.nodeto 26.13.0 (current LTS).AI-assisted (OpenCode: claude-opus-5-5, claude-sonnet-5-5); reviewed by Stuart B. Wilkins (@stuwilkins).