Skip to content

Fix f_hutch_cam PV prefix - #150

Merged
Nghia T. Vo (nghia-vo) merged 2 commits into
NSLS2:mainfrom
sligara7:fix-f-hutch-cam-prefix
Nov 12, 2026
Merged

Nghia T. Vo (nghia-vo) merged 2 commits into
NSLS2:mainfrom
sligara7:fix-f-hutch-cam-prefix

Conversation

@sligara7

Copy link
Copy Markdown
Contributor

f_hutch_cam used XF:27IDA-BI{GigE-Cam:5}. The hutch-f-cam IOC (ioc_host_vars xf/hex/xf27id1-cam1.nsls2.bnl.gov/hutch-f-cam.yml) serves XF:27ID1-ES{GigE-Cam:5}, so the camera worked in CSS but not in bluesky (reported by Zhong).

  • Fixes the prefix in profiles/collection.py and in the GUI's camera list.
  • Adds tests/test_device_prefixes.py, which pins each IOC-served detector/camera prefix (profile and GUI) to its IOC's PREFIX. It fails on the first commit and passes on the second. The other prefixes already matched.

Verification: mock/unit tests (652 passed, pyright clean). At HEX, from xf27id1-ws2 (read-only): caget 'XF:27ID1-ES{GigE-Cam:5}cam1:Model_RBV' → GT2460; the old prefix is not found. After merge: await f_hutch_cam.connect() at the beamline.

Pins each IOC-served detector and camera prefix, in the profile and in the GUI's camera list, to the IOC's PREFIX in ioc_host_vars. Fails for f_hutch_cam.

Assisted-by: copilot:claude-opus-5-5
The hutch-f-cam IOC serves XF:27ID1-ES{GigE-Cam:5} (ioc_host_vars); XF:27IDA-BI{GigE-Cam:5} is not found from xf27id1-ws2, so bluesky could not reach the camera while the CS-Studio screen could.

Assisted-by: copilot:claude-opus-5-5

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the F-hutch camera PV prefix correction.

No open issues 🎉

What changed in this PR

Corrects the F-hutch camera’s PV prefix to match its IOC, aligning the Bluesky collection profile and GUI with the working camera endpoint.

Changes:

  • Updates f_hutch_cam to use XF:27ID1-ES{GigE-Cam:5} in both locations.
  • Adds regression tests that check configured detector and camera prefixes against expected IOC values.
File Description
tests/​test_device_prefixes.py Adds prefix checks for the collection profile and GUI cameras.
src/​hextools/​profiles/​collection.py Corrects the F-hutch camera’s detector prefix.
src/​hextools/​gui/​__main__.py Applies the corrected prefix to the GUI camera viewer.

Review effort: Balanced

@nghia-vo
Nghia T. Vo (nghia-vo) merged commit f6525c1 into NSLS2:main Nov 12, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants