[Anthony Sligar (sligara7)]

Restart detector preview once at the end of a tomography scan, not after every step of it.

• tomo_flyscan and tomo_dark_flat take restart_preview: bool = True (beside use_shutter); run on their own they still return the cameras to preview.
• tomo_nd_step_scan and its wrappers (tomo_flyscan_loop, tomo_1d_step_scan, tomo_2d_step_scan) run them with restart_preview=False, and restart preview once when the whole scan ends (also on abort), unless restart_preview=False.
• tomo_dark_flat still restores each camera's exposure either way.
• enable_preview_mode supports the Phantom: it stops a recording and turns on live preview (Preview). The Phantom's prepare turns live preview off, since the IOC (ADPhantom afefafc) refuses to download while it runs.

Verification

Mock tests only (no sim, TST or beamline):

• tests/tomography and tests/detectors/test_phantom.py: pass; the new or updated tests fail on the code before each change.
• Unit suite (tests, excluding tests/gui): 562 passed, exit 0.
• pyright 0 errors; pre-commit passed.

[Copilot]

🟡 Changes recommended

Adding restart_preview before sample_name breaks existing positional calls, losing sample metadata, unexpectedly enabling preview, and shifting subsequent arguments.

1 open issue

• Adding parameter before sample_name breaks positional calls · New

What changed in this PR

This PR makes Kinetix preview restart optional after tomo_flyscan, leaving detectors in their post-scan state by default.

Changes:

• Adds restart_preview=False and gates preview cleanup on this option.
• Preserves shutter closure, motor stopping, and velocity restoration.
• Updates default-behavior assertions and adds a test for explicitly restarting preview.

File	Description
tests/​tomography/​test_flyscans.py	Tests default cleanup behavior and explicit preview restart.
src/​hextools/​tomography/​flyscans.py	Adds and documents the preview-restart option and conditional cleanup.

_{Review effort: Balanced}

[Nghia T. Vo (nghia-vo)]

For tomo_flyscan only it should be set to True be default. Only in tomo_nd it sets to False

[Anthony Sligar (sligara7)]

Done in 92ea2c2: tomo_flyscan (and tomo_dark_flat) default to restart_preview=True; tomo_nd_step_scan runs them with False and restarts preview once at the end.

[Jakub Wlodek (jwlodek)]

Minor point, otherwise looks good.

[Copilot]

🟡 Changes recommended

Abort-path preview restoration lacks coverage with a mock Kinetix detector, since existing tests either complete normally or skip the relevant cleanup.

1 open issue

• Add abort-path coverage for Kinetix preview restoration · New

1 resolved since last review

• Adding parameter before sample_name breaks positional calls

_{Review effort: Balanced}

[Nghia T. Vo (nghia-vo)]

restart_preview parameter needs to be used in tomo_nd, 1d_2d where we set to False for the loop. But at the end we set it to True.

[Copilot]

🔵 Needs a closer look

Phantom recording, preview, and download sequencing depends on ADPhantom afefafc behavior that mocks cannot verify, requiring IOC or detector-owner validation of safe shutdown and restart timing.

1 open issue

• Add abort-path coverage for Kinetix preview restoration

_{Review effort: Balanced}