[samuil-banti-wpenigne]

CSS allows the default value of var to be empty i.e.

  /* A: empty fallback, --w is undefined */
  .a { border: var(--w,) solid red; }

  /* B: empty fallback, --w is defined */
  .b { --w: 5px; border: var(--w,) solid red; }

The goal of the PR is to enable us to parse such cases.

[coveralls]

coverage: 76.388% (+0.7%) from 75.673% — samuil-banti-wpenigne:resolve-issue-with-empty-default-value-for-var-method into MyIntervals:main

[JakeQZ]

Thanks again for another excellent contribution; you have been quite prolific, @samuil-banti-wpenigne <3.

The code changes look near-perfect. But I think the tests could be extended and improved. See individual comments.

[JakeQZ]

This test belongs in Sabberworm\CSS\Tests\Functional\Value\CSSFunctionTest because it depends on ParserState. Putting it there will involve creating that TestCase class since it does not yet exist.

[JakeQZ]

This test should only be testing the parsing, not also the rendering. We can do $result->getArrayRepresentation() and make assertions on the returned array representation.

[JakeQZ]

Looking good now. But I think we need a converse test for CSSFunction. And there's a typo in the changelog entry.

[JakeQZ]

Super. Thanks again for contributing <3.

[oliverklee]

Thank you, @samuil-banti-wpenigne! ❤️