Repository navigation
Add EngineSignature to FuelFlowSimulation plus some fixes - #2373
Merged
Merged
Conversation
Add a List<EngineSignature> to each FuelStat segment so that we can fingerprint different stages. This can get used in e.g. PSG for logical stage detection. All SimPartModules now carry an Index into the actual KSP Vessel Modules list. And some other random fixes: - SimPartModule gets a virtual Clear() - The SimVessel pool reset also clears ActiveRcs. - UpdateActiveEngines drops engines that an AutoCutoff symmetry counterpart shut down after they were added. - Run() clears the resource and RCS drains on its parts and empties its part sets in a finally. - Fix division by zero in SpoolUpTime computation that resulted in NaN.
Contributor
✅ Build Artifact 🚀MechJeb2-5a04762.zip (built from 577177f) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a List to each FuelStat segment so that we can fingerprint different stages. This can get used in e.g. PSG for logical stage detection. All SimPartModules now carry an Index into the actual KSP Vessel Modules list.
And some other random fixes: