Repository navigation
Phone layout for the game screens, camera-ready gate, tap-to-score as practice - #30
Merged
Merged
Conversation
… practice On a phone (under 640 px) the site no longer shrinks a 1920 x 1080 stage to a fifth of its size: the stage is 480 px wide, the header and menu panel are compact, and the desktop tab arch is hidden. In play the camera is on top, then the sign to show (the existing neon sign picture) with no letter grid. Tapping the sign still scores but makes the game a practice game: the report says so and it is not put on the leaderboard (server rule, tested). START now waits for the camera and hand tracking (loaded in the lobby instead of during the countdown, which is what made a phone game start late), and opens up anyway if either fails or it takes over 20 seconds. Desktop layout is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No new design: the existing SignHero look, narrowed for phones. Desktop is unchanged.
What a phone shows (under 640 px wide)
Camera-ready gate (all screen sizes)
Hand tracking used to be loaded when the game started, so on a phone the clock ran while it was still compiling (about 6 s from connecting to the first frame in the last mobile game). It is now loaded in the lobby, and START says "STARTING CAMERA..." until the camera and tracking are ready. It opens up anyway if the camera or tracking fails, or after 20 s, so nobody is blocked.
Tap = practice
Tapping the shown sign scores (a fallback if the camera won't work), but that game is marked practice: the report says "PRACTICE GAME · NOT ON THE LEADERBOARD" and the server does not create a leaderboard entry (
player.updateFinalStatstakespractice;Player.practiceis additive). Camera games are ranked as before. On desktop, clicking a tile is unchanged.Tested
tsc.Not in this PR: tablet-specific layout and a phone pass for songs/community (both still use the desktop stage).