Repository navigation
chore(lane): daily maintenance 2026-10-28 - #134
Merged
Merged
Conversation
…ation command What was stale: the regeneration command in docs/MOON_PATCH_QUEUE.md passed `--local` to `cargo xtask transform`. The Transform subcommand defines only --zed-tag, --zed-path, --output and --versioned-deps, so clap rejects the documented command with "unexpected argument '--local'" (exit 2). What the code does now: path dependencies are the default (main.rs passes `!versioned_deps` as `use_local_deps`); `--versioned-deps` opts into version dependencies. The doc now says so. Verified: `cargo xtask transform --help` lists no --local, and running the command with --local exits 2 before touching any directory. Reviewer: Codex (all three changed claims confirmed against main.rs, transform.rs and transform/manifest.rs). Other documents read today and current: crates/moon-gpui/README.md, crates/moon-ui-gallery/README.md.
Found by the hunt lane in moon-refineable / its derive macro. Input: a refinement generated by #[derive(Refineable)] in which only one field (here one field of a nested #[refineable] refinement) is set. Documented result: the generated `<Name>Refinement::is_some` doc comment said "Returns `true` if all fields are `Some`", so it should return false. Actual result: it returns true; the body returns on the first field whose `is_some()` is true. The code, not the comment, is what callers depend on: `Style::text_style` (moon-gpui/src/style.rs) returns the text refinement whenever `self.text.is_some()`, so a style that overrides only the text colour keeps it; with the documented "all fields" meaning that override would be discarded. The macro's own Debug impl uses the same presence meaning for nested refinements. So the doc comment is corrected and no behaviour changes. Proof: a throwaway integration probe in crates/moon-refineable/tests (deleted, not committed) asserted the documented meaning and failed on origin/master at 11caff6 ("is_some returned true with only one nested field set"). Re-run: derive a two-level refinement, set one nested field, call is_some(). Checks: cargo fmt --all, cargo clippy and cargo test for moon-derive-refineable and moon-refineable, cargo check -p moon-gpui. Reviewer: Codex (no findings; confirmed the text matches the generated body and that Style::text_style and the generated Debug rely on it).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs
Stale: the regeneration command in
docs/MOON_PATCH_QUEUE.mdpassed--localtocargo xtask transform. TheTransformsubcommand only defines--zed-tag,--zed-path,--outputand--versioned-deps, so clap rejects the documented command with "unexpected argument '--local'" (exit 2).What the code does now: path dependencies are the default (
main.rspasses!versioned_depsasuse_local_deps), and--versioned-depsopts into version dependencies. The doc now says so.Verified:
cargo xtask transform --helplists no--local, and running the command with--localexits 2 before touching any directory.Reviewer: Codex. It confirmed all three changed claims against
main.rs,transform.rsandtransform/manifest.rs.Also read today and still current:
crates/moon-gpui/README.md,crates/moon-ui-gallery/README.md. No issues opened.Hunt
Ground:
moon-refineableand its derive macro (moon-derive-refineable).Input: a refinement generated by
#[derive(Refineable)]with only one field set (one field of a nested#[refineable]refinement).Documented result: the generated
<Name>Refinement::is_somesaid "Returnstrueif all fields areSome", so it should returnfalse.Actual result: it returns
true, because the body returns on the first set field.Why the doc is the part that is wrong: callers rely on what the code does.
Style::text_style(moon-gpui/src/style.rs) returns the text refinement wheneverself.text.is_some(). With the documented "all fields" meaning, a style that overrides only the text colour would lose that override. The macro's generatedDebuguses the same "any field set" meaning. So only the doc comment changes, and no behaviour changes.Proof: a throwaway probe in
crates/moon-refineable/testsasserted the documented meaning and failed onorigin/masterat11caff6. The probe was deleted and is not committed. Five more edge probes passed and were deleted:refined⊇is_superset_of, thesubtractround-trip, cascade order with an emptied slot,subtractagainst an empty refinement, andFrom<Refinement>.Checks:
cargo fmt --all;cargo clippyandcargo testfor both crates;cargo check -p moon-gpui.Reviewer: Codex. No findings.
Leftovers
Quiet: no open lane pull requests.
Fix
Quiet: both open
auto-foundissues (#127, #129) carryneeds-human.