Repository navigation
fix(juce): offer the activation link when the browser can't be opened - #44
Merged
Merged
Conversation
On Windows, juce::URL::launchInDefaultBrowser() is a bare ShellExecute, which fails when no default browser is set. The controller noticed and told onDiagnostic, but the "Waiting for activation" screen still said it had opened the browser and offered only Cancel, so the user was stuck. - The screen now always offers "Browser didn't open? Copy the link" once the link has arrived, since a launch can also report success while nothing visible happens. - When the launch fails, the screen says so and makes "Copy activation link" its main action, so the activation can be finished in any browser, on this computer or another. Both show "Link copied" briefly. - At the minimum panel size the spinner gives way so the copy and the button still fit. - New ActivationController::browserOpenFailed() for custom UIs, and setPreviewBrowserLink() for previews and snapshot tests. - Controller tests, a new 02b snapshot, and docs.
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 17, 2026
## [4.10.1](v4.10.0...v4.10.1) (2026-10-17) ### Bug Fixes * **juce:** offer the activation link when the browser can't be opened ([#44](#44)) ([e5b2dc9](e5b2dc9))
|
🎉 This PR is included in version 4.10.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows,
juce::URL::launchInDefaultBrowser()is a bareShellExecute, which fails when no default browser is set, yet the "Waiting for activation" screen still said it had opened the browser and offered only Cancel. The screen now always offers "Browser didn't open? Copy the link", and when the launch fails it says so and makes Copy activation link its main action, so the activation can be finished in any browser on this computer or another (both briefly confirm "Link copied", and the layout still fits at the minimum panel size). Custom UIs getActivationController::browserOpenFailed(), andsetPreviewBrowserLink()lets previews and snapshot tests show the link. Snapshot02-activatingchanges,02b-activating-no-browseris new, and16-theme-ember-activatingnow renders the no-browser state. Tested with new controller tests (the JUCE suite passes on 8.0.4 and 6.1.3), snapshot renders at the default and minimum sizes, and a manual click of both controls to confirm the link reaches the clipboard; the Windows path itself is left to CI.