Repository navigation
fix: find Canadian addresses whose street lost its trailing direction when a unit was removed - #616
Conversation
… when a unit was removed
Merging this PR will not alter performance
Comparing Footnotes
|
Speed, full index: no slowdown over 15%DetailsSearchAddressTime in ms over 1993 cases, each the fastest of 3 requests.
SuggestAddressTime in ms over 2154 checks, each the fastest of 3 requests.
ReverseGeocodeTime in ms over 1990 cases, each the fastest of 3 requests.
Fails when the total, p50, p90 or p99 of any table is more than 15% slower. Runs of one binary differ by up to 5%; the max is one request and only reported. Base |
Gold check, full index: no regressionsBaseline vs candidate (48004 shared cases)
Pass rate by countryNo expected country's passing checks changed. Runs
|
Summary
A Canadian address typed with a unit, like "18 Hemlock Road- Unit-C, Delhi, ON", can now resolve to the indexed street "Hemlock Road East" when removing the unit leaves an otherwise exact street name without its trailing direction. The full postcode and town must still agree, and ambiguous or conflicting cases stay unmatched.
Changes
Review focus
Check the corroboration rules in
unique_canadian_house_in_postcode. No new data, builder hash change or dependency.