Skip to content

fix: find Canadian addresses whose street lost its trailing direction when a unit was removed - #616

Merged
Mokto merged 1 commit into
mainfrom
fix/ca-unit-direction-recall
Nov 21, 2026
Merged

Mokto merged 1 commit into
mainfrom
fix/ca-unit-direction-recall

Conversation

@Mokto

@Mokto Mokto commented Nov 20, 2026

Copy link
Copy Markdown
Owner

Summary

A Canadian address typed with a unit, like "18 Hemlock Road- Unit-C, Delhi, ON", can now resolve to the indexed street "Hemlock Road East" when removing the unit leaves an otherwise exact street name without its trailing direction. The full postcode and town must still agree, and ambiguous or conflicting cases stay unmatched.

Changes

  • Recover the street only when the unit was removed and the typed name matches the indexed name apart from one trailing direction.
  • Use only the selected indexed house. The index must back the postcode independently: either the house's own postcode, or a missing own postcode on a street whose only stored postcode agrees.
  • Refuse when the same number maps to distinct coordinates, including distant duplicate slots.
  • Never rewrite a direction the query already states.
  • Synthetic Delhi streets and search cases cover the positive case, an ambiguous number, an explicit other direction, a conflicting postcode and a different town.

Review focus

Check the corroboration rules in unique_canadian_house_in_postcode. No new data, builder hash change or dependency.

@codspeed

codspeed Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 8 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing fix/ca-unit-direction-recall (3e10935) with main (69cef8c)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions

Copy link
Copy Markdown

Speed, full index: no slowdown over 15%

Details

SearchAddress

Time in ms over 1993 cases, each the fastest of 3 requests.

Total p50 p90 p99 Max
base 5746.9 1.8 5.2 20.0 63.7
head 5306.2 1.7 4.7 19.1 58.2
change -8% -6% -10% -5% -9%

SuggestAddress

Time in ms over 2154 checks, each the fastest of 3 requests.

Total p50 p90 p99 Max
base 2893.2 1.0 1.9 7.3 22.6
head 2734.7 1.0 1.7 7.2 20.6
change -5% -5% -7% -2% -9%

ReverseGeocode

Time in ms over 1990 cases, each the fastest of 3 requests.

Total p50 p90 p99 Max
base 1613.4 0.7 1.1 2.4 4.7
head 1492.7 0.7 1.0 1.9 4.2
change -7% -7% -10% -19% -10%

Fails when the total, p50, p90 or p99 of any table is more than 15% slower. Runs of one binary differ by up to 5%; the max is one request and only reported.

Base 69cef8c → 3e10935, one after the other in one pod on the same node and index.

@github-actions

Copy link
Copy Markdown

Gold check, full index: no regressions

Baseline vs candidate (48004 shared cases)

RPC Checked Pass base Pass head Change Results changed
ResolveRegion 9660 9472 9472 0 0
ReverseGeocode 47259 41855 41855 0 0
ReverseGeocode (country/area only) 144 144 144 0 0
ReverseGeocode offset 39626 38190 38190 0 0
SearchAddress 47637 41948 41948 0 0
SearchAddress (location only) 144 144 144 0 0
SuggestAddress 51414 43820 43820 0 0
SuggestAddress (flag off) 215 215 215 0 0
SuggestAddress (location only) 144 144 144 0 0

Pass rate by country

No expected country's passing checks changed.

Runs
  • baseline: base, backend overture-index data index f8ef21ed0691, consumer binary fc650bce2172 models 2de098b5667f
  • candidate: head, backend overture-index data index f8ef21ed0691, consumer binary cba62f9c0f0b models 2de098b5667f

@Mokto
Mokto merged commit df47dac into main Nov 21, 2026
20 checks passed
@Mokto
Mokto deleted the fix/ca-unit-direction-recall branch November 21, 2026 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant