Repository navigation
fix: find Queens addresses whose civic number is written without its hyphen - #613
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
Speed, full index: no slowdown over 15%DetailsSearchAddressTime in ms over 1993 cases, each the fastest of 3 requests.
SuggestAddressTime in ms over 2154 checks, each the fastest of 3 requests.
ReverseGeocodeTime in ms over 1990 cases, each the fastest of 3 requests.
Fails when the total, p50, p90 or p99 of any table is more than 15% slower. Runs of one binary differ by up to 5%; the max is one request and only reported. Base |
Gold check, full index: no regressionsBaseline vs candidate (48004 shared cases)
Pass rate by countryNo expected country's passing checks changed. Runs
|
Summary
Queens addresses are indexed with a hyphenated number such as
43-28, but are often typed as4328. Those queries now find the indexed house when the state, ZIP code, road and Queens locality all agree.Changes
Review focus
Check the Queens locality test and the ambiguity rejection in
src/resolver.rs, since they keep this fallback narrow.