Skip to content

fix: find Queens addresses whose civic number is written without its hyphen - #613

Merged
Mokto merged 1 commit into
mainfrom
fix/na-queens-missing-hyphen
Nov 20, 2026
Merged

Mokto merged 1 commit into
mainfrom
fix/na-queens-missing-hyphen

Conversation

@Mokto

@Mokto Mokto commented Nov 20, 2026

Copy link
Copy Markdown
Owner

Summary

Queens addresses are indexed with a hyphenated number such as 43-28, but are often typed as 4328. Those queries now find the indexed house when the state, ZIP code, road and Queens locality all agree.

Changes

  • A four or five digit New York number is also tried with a hyphen before its last two digits.
  • The hyphenated match is accepted only for an existing, non-interpolated house in the same state and ZIP, on a corroborated road, within a Queens locality.
  • If candidates have distinct coordinates, the lookup abstains instead of guessing.
  • The road-variant retry skips a rewrite identical to the original query.
  • Synthetic fixtures (fictional places and streets) cover the match and the cases that must stay unmatched: wrong town, wrong ZIP, wrong number and wrong road.

Review focus

Check the Queens locality test and the ambiguity rejection in src/resolver.rs, since they keep this fallback narrow.

@codspeed

codspeed Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 8 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing fix/na-queens-missing-hyphen (472ea24) with main (8e1d028)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions

Copy link
Copy Markdown

Speed, full index: no slowdown over 15%

Details

SearchAddress

Time in ms over 1993 cases, each the fastest of 3 requests.

Total p50 p90 p99 Max
base 5315.7 1.7 4.8 20.1 57.6
head 5370.7 1.6 5.0 20.3 57.7
change +1% -2% +4% +1% +0%

SuggestAddress

Time in ms over 2154 checks, each the fastest of 3 requests.

Total p50 p90 p99 Max
base 2708.5 1.0 1.7 7.5 19.8
head 2777.3 1.0 1.9 7.2 20.3
change +3% +3% +8% -5% +3%

ReverseGeocode

Time in ms over 1990 cases, each the fastest of 3 requests.

Total p50 p90 p99 Max
base 1551.2 0.7 1.0 2.2 7.5
head 1489.4 0.7 0.9 1.9 4.7
change -4% -5% -4% -12% -38%

Fails when the total, p50, p90 or p99 of any table is more than 15% slower. Runs of one binary differ by up to 5%; the max is one request and only reported.

Base 8e1d028 → 472ea24, one after the other in one pod on the same node and index.

@github-actions

Copy link
Copy Markdown

Gold check, full index: no regressions

Baseline vs candidate (48004 shared cases)

RPC Checked Pass base Pass head Change Results changed
ResolveRegion 9660 9472 9472 0 0
ReverseGeocode 47259 41855 41855 0 0
ReverseGeocode (country/area only) 144 144 144 0 0
ReverseGeocode offset 39626 38190 38190 0 0
SearchAddress 47637 41948 41948 0 0
SearchAddress (location only) 144 144 144 0 0
SuggestAddress 51414 43820 43820 0 0
SuggestAddress (flag off) 215 215 215 0 0
SuggestAddress (location only) 144 144 144 0 0

Pass rate by country

No expected country's passing checks changed.

Runs
  • baseline: base, backend overture-index data index f8ef21ed0691, consumer binary 19af63f1530f models 2de098b5667f
  • candidate: head, backend overture-index data index f8ef21ed0691, consumer binary fc650bce2172 models 2de098b5667f

@Mokto
Mokto merged commit 69cef8c into main Nov 20, 2026
20 checks passed
@Mokto
Mokto deleted the fix/na-queens-missing-hyphen branch November 20, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant