Repository navigation
fix: parallelism environment variable should be reset - #408
Merged
Merged
Conversation
 [Medium impact] The change affects the shared encoding path used by `StaticModel` callers. The restore logic needs coordination across overlapping calls before merging. Reviews (1) · Last reviewed commit: "fix: parallelism environment variable sh..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+130
to
+131
| model.encode(["word1 word2"] * 15_000, use_multiprocessing=True) | ||
| assert os.environ.get("TOKENIZERS_PARALLELISM") == previous |
There was a problem hiding this comment.
The new test checks restoration only after a successful encode. Add a case where a batch raises, then check that the original environment value is restored and the exception still reaches the caller. Otherwise, moving cleanup outside finally would pass this test while leaving parallelism disabled after failed requests.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiprocessing turned off tokenizers parallelism, but we never turned it back on.