Skip to content

Modify cancelPush() to support push v2 - #4747

Open
Withalion wants to merge 2 commits into
feature/sync-v2from
feature/cancel-push-v2
Open

Modify cancelPush() to support push v2#4747
Withalion wants to merge 2 commits into
feature/sync-v2from
feature/cancel-push-v2

Conversation

@Withalion

@Withalion Withalion commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

Done 2 things:

  • calling cancel on push now just aborts pending calls for push v2 and sends cancel transaction request for push v1
  • refactored abort flows for push*reply slots, so we won't read from closed devices

@Withalion
Make cancelPush send cancel request only for v1 push
fd96318
@Withalion
Refactor readAll() for aborted network calls
564494d 
On aborted network calls the underlying device is already closed and
calling readAll() on it throws warning.
@Withalion
Withalion requested a review from tomasMizera October 9, 2026 09:39
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build ❌ Build failed or not found. #7405
linux Build ❌ Build failed or not found. #7431
win64 Build 📬 Mergin Maps 66071 win64 Expires: 07/01/2027 #6607
Android Build 📬 Mergin Maps 871751 APK [arm64-v8a] Expires: 07/01/2027 #8717
📬 QR code Google Play Store #8717
Android Build 📬 Mergin Maps 871711 APK [armeabi-v7a] Expires: 07/01/2027 #8717
📬 QR code Google Play Store #8717
iOS Build 📬 Build number: 26.10.965711 #9657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomasMizera tomasMizera Awaiting requested review from tomasMizera

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Withalion