Repository navigation
Add database-configuration.max-lifetime, in seconds, and pass it to Sarah as the Hikari connection max lifetime - #271
Merged
Conversation
… Sarah as the Hikari connection max lifetime
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
database-configuration.max-lifetime, in seconds, and pass it to Sarah as the Hikari connection max lifetime. Depends on GroupeZ-dev/Sarah#24, which addsDatabaseConfiguration.withMaxLifetime.1800keeps the current 30-minute behavior.0keeps connections until the pool closes. A missing or negative value leaves Sarah's 30-minute default in place.database-configuration.ymloverrides the plugin config, same as the other database settings. Sarah is bumped to 1.26. in the PRThis only affects MySQL and MariaDB. SQLite does not use the pool. Hikari rejects any positive lifetime under 30 seconds. This pull request will not build until Sarah 1.26 is published.
Test plan
max-lifetime: 1800connects and behaves like the previous 30-minute lifetime.60, is accepted by the pool.max-lifetime: 0leaves connections open until the pool closes.config.yml, still uses 30 minutes.database-configuration.ymloverrides the plugin config.