Repository navigation
fix(config,ui): Settings no longer reads as an overlaid window under NVDA (#514) - #517
Merged
Merged
Conversation
…NVDA (#514) Host (src/config_ui/main.cpp): - Hand keyboard focus to the WebView2 (MoveFocus PROGRAMMATIC) on first paint, after each navigation, on WM_ACTIVATE/WM_SETFOCUS, and when a second launch re-opens the window (WM_APP_FOCUS_PAGE). Only while the window is active. - MoveFocusRequested cycles Tab back into the page instead of the empty host window. - WS_SYSMENU for Alt+Space and the taskbar menu; WM_NCCALCSIZE still removes the caption. UI: - lib/dialog.js: while a dialog is open, the siblings of each ancestor of the top dialog are inert (new layers too, the live region kept), so only the dialog is in the accessibility tree; works for the in-page app-list dialog and full-window prompts. Focus restore after release. - SaveCapsule: role=region "Unsaved changes" instead of role=status around the buttons; the page announces the first unsaved change once (Save/Discard already announce). - TitleBar: a div, not a banner landmark; brand aria-hidden; rendered after the page in the DOM (grid-row keeps it on top), so window buttons come last. Settings opens with focus on main; main is named "Search results" while searching. - Tests: background inert while a prompt / app list is open (checked against Chromium's AX tree), capsule not a live region, title bar order, initial focus. - docs/architecture/09 updated. Closes #514 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BjTV6Wj6XLqULZWUmqiVYJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #514. Field report: Settings had 'an overlaid window above it' under NVDA.
src/config_ui/main.cpp): moves keyboard focus into the WebView2 on ready, navigation, activation, WM_SETFOCUS and single-instance re-open; MoveFocusRequested cycles Tab back into the page; WS_SYSMENU for Alt+Space.ui/src/lib/dialog.js: everything outside the topmost dialog is inert while it is open (live region excluded), restored before focus returns.role=regioninstead of a live region around buttons; first unsaved change announced once.main.Verification:
build.bat check,build.bat config, Playwright 217/217, test:rules pass. Deployed signed UIAccess build (combined with #515): Settings opens. Not tested with NVDA.🤖 Generated with Claude Code
https://claude.ai/code/session_01BjTV6Wj6XLqULZWUmqiVYJ