Skip to content

Stabilize scheduled CI by making Supertrend description assertion case-insensitive - #323

Merged
Mathieu2301 merged 4 commits into
mainfrom
copilot/fix-github-actions-job
Oct 1, 2026
Merged

Mathieu2301 merged 4 commits into
mainfrom
copilot/fix-github-actions-job

Conversation

Copilot AI commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

The scheduled Tests workflow failed due to a brittle assertion in tests/indicators.test.ts that expected exact capitalization for the Supertrend indicator description. TradingView returned semantically identical text with different casing (strategy vs Strategy), causing a false negative.

  • Root cause

    • Indicator metadata casing changed upstream ("Supertrend Strategy" → "Supertrend strategy"), while the test required exact string equality.
  • Change

    • Replaced strict equality with a case-insensitive full-string match for the Supertrend description.
    • Scope is intentionally limited to the single failing assertion.
  • Why this shape

    • Keeps validation strict on content (Supertrend strategy) while removing non-functional casing brittleness.
// before
expect(indicators.SuperTrend.description).toBe('Supertrend Strategy');

// after
expect(indicators.SuperTrend.description).toMatch(/^Supertrend strategy$/i);

Co-authored-by: Mathieu2301 <21021423+Mathieu2301@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job by identifying root cause Stabilize scheduled CI by making Supertrend description assertion case-insensitive Sep 30, 2026
Copilot AI requested a review from Mathieu2301 September 30, 2026 00:39
@Mathieu2301
Mathieu2301 marked this pull request as ready for review September 30, 2026 00:40
Co-authored-by: Mathieu2301 <21021423+Mathieu2301@users.noreply.github.com>
auto-merge was automatically disabled October 1, 2026 00:49

Head branch was pushed to by a user without write access

Copilot AI requested a review from Mathieu2301 October 1, 2026 00:50
Co-authored-by: Mathieu2301 <21021423+Mathieu2301@users.noreply.github.com>
Copilot AI requested a review from Mathieu2301 October 1, 2026 01:01
@Mathieu2301
Mathieu2301 enabled auto-merge October 1, 2026 01:03
@Mathieu2301
Mathieu2301 merged commit 803ba3f into main Oct 1, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants