Stabilize scheduled CI by making Supertrend description assertion case-insensitive - #323
Merged
Merged
Conversation
Co-authored-by: Mathieu2301 <21021423+Mathieu2301@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job by identifying root cause
Stabilize scheduled CI by making Supertrend description assertion case-insensitive
Sep 30, 2026
Mathieu2301
approved these changes
Sep 30, 2026
Mathieu2301
marked this pull request as ready for review
September 30, 2026 00:40
Mathieu2301
enabled auto-merge
September 30, 2026 00:40
Co-authored-by: Mathieu2301 <21021423+Mathieu2301@users.noreply.github.com>
auto-merge was automatically disabled
October 1, 2026 00:49
Head branch was pushed to by a user without write access
Mathieu2301
approved these changes
Oct 1, 2026
Co-authored-by: Mathieu2301 <21021423+Mathieu2301@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scheduled Tests workflow failed due to a brittle assertion in
tests/indicators.test.tsthat expected exact capitalization for the Supertrend indicator description. TradingView returned semantically identical text with different casing (strategyvsStrategy), causing a false negative.Root cause
"Supertrend Strategy"→"Supertrend strategy"), while the test required exact string equality.Change
Why this shape
Supertrend strategy) while removing non-functional casing brittleness.