Repository navigation
handle entry types without a dedicated model, such as calculations in validator - #2451
Merged
ml-evs merged 3 commits intoNov 2, 2026
Conversation
… property_definitions.py
…s in the strict docs build
…`, against the properties shared by all entry types
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2451 +/- ##
==========================================
+ Coverage 90.21% 90.58% +0.36%
==========================================
Files 78 79 +1
Lines 5039 5364 +325
==========================================
+ Hits 4546 4859 +313
- Misses 493 505 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ml-evs
approved these changes
Nov 2, 2026
ml-evs
merged commit Nov 2, 2026
1db0cd4
into
Materials-Consortia:ml-evs/property-definitions
12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: to be merged on top of #2442
calculationsis in the validator's entry endpoints, butVALIDATOR_CONFIG.entry_schemasonly covers the types inENTRY_INFO_SCHEMAS. So validating any server that servescalculationsfails with an internal error,KeyError: 'calculations'.This PR gives such entry types the schema of
EntryResource, which covers the properties shared by all entry types and is all thatcalculationshas in v1.3. It also falls back toValidatorEntryResponseManyin_test_unknown_provider_property, as_test_multi_entry_endpointalready does. A new test runs the validator against the reference server with an emulatedcalculationsentry type. It fails without this change.