Repository navigation
feat(yasgui): hide the query editor and redesign the share popup - #259
Merged
Merged
Conversation
Hide query folds the editor to one line so the results take the card (#258). The state is kept per tab, can be toggled from Ctrl+K, and share links open that way with hideQuery=true ("Show only the results" in the share popup). An update or invalid query from a link is always shown. New tabs can start hidden with the hideQuery config option. The share popup moves to its own module in the MatData look: the link with a Copy button, the option, the shortener and the cURL, PowerShell and wget commands, with inline Copied feedback and a credentials note instead of toasts. It closes on Escape and spans a narrow viewport.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #258.
Hide the query
queryHiddenin the persisted tab JSON).hideQuery=trueopens the link with the query hidden. The share popup offers this as "Show only the results", ticked by default when the tab's query is hidden. An update or invalid query from a link is not run, so the editor is always shown in that case.hideQuery: trueopens new tabs with the query hidden (default false).Share popup redesign
packages/yasqe/src/sharePopup.tsand uses the MatData look. It has a "Link" section (read-only URL field with a Copy button, the hide-query option and Shorten link) and a "Command line" section (cURL, PowerShell and wget rows).createShareableLink(yasqe, options?)now receives{ hideQuery }, and a newshareHideQueryOptionconfig shows the option. One-argumentcreateShareableLinkfunctions keep working.Docs
hideQueryandshareHideQueryOption.Tests
share-link-browser.ts: a hideQuery link (state, popup option and link, Show query), and a hidden update query that gets shown.util:validateTsclean on the changed files.