Repository navigation
feat: add display average to students toggle - #8243
AngelsandDevsLOL wants to merge 4 commits into
Conversation
Coverage Report for CI Build 40810246972Coverage increased (+0.001%) to 91.064%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
| @@ -0,0 +1,5 @@ | |||
| class AddDisplayAverageToStudentsToAssignmentProperties < ActiveRecord::Migration[8.1] | |||
| def change | |||
| add_column :assignment_properties, :display_average_to_students, :boolean, default: false, null: false | |||
There was a problem hiding this comment.
I realized that it's better to make the default true here to preserve backwards compatibility (as the assignment average is currently shown by default). Please rollback this migration, edit the file, then redo the migration.
| end | ||
|
|
||
| def display_average_to_students | ||
| false |
There was a problem hiding this comment.
Similar to my comment below, please make this true (as it affects grade entry forms, which show the average by default)
| :enable_student_tests, :allow_remarks, | ||
| :display_grader_names_to_students, | ||
| :display_median_to_students, :group_name_autogenerated, | ||
| :display_average_to_students, :display_median_to_students, :group_name_autogenerated, |
There was a problem hiding this comment.
I'd like to avoid backwards compatibility issues with CSV upload prior to this change, so please add this new field to the end of the list (affects Course#upload_assignment_list)
|
Oh and @AngelsandDevsLOL please also add a screenshot showing the UI changes for the instructor (assignment form) and students (with the different boolean options for this setting) |
Proposed Changes
Introduces a new
Display average to studentstoggle, similar to the currentDisplay median to studentstoggle when an instructors edits an assignment in the settings. This PR creates a migration and creates a new column within theAssignmentPropertiestable, calledDisplayAverageToStudents. This is similar to the currentDisplayMedianToStudentscolumn, where averages and medians are not displayed by default.When a student views their grade summary, they will see the average only if the toggle is on (and the grades are released).
Screenshots of your changes (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments