[Naragod]

Proposed Changes

Old code for LMS grade columns sits in the assignment form logic. Zero pages call it. The new and edit assignment forms had LMS checkboxes until #6350 in Feb 2023. That PR moved them to the LMS settings page. The code that read them stayed behind in process_assignment_form.

A hand-made request to that code fails. On create, it queues LtiLineItemJob before MarkUs saves the assignment. The job call fails on the unsaved record. A rescue in create hides the error.

Implementation

• Remove the lti_deployment block from process_assignment_form. The LMS settings page starts LtiLineItemJob through create_lti_line_items.
• Remove @lti_deployments from new. The LMS settings page is the one page that reads it.
• Remove @lti_deployments from edit. The LMS settings page is the one page that reads it.

Screenshots of your changes (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type	Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)	X
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
📖 Documentation update (change that updates documentation)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

• I have performed a self-review of my changes.
  • Check that all changed files included in this pull request are intentional changes.
  • Check that all changes are relevant to the purpose of this pull request, as described above.
• I have added tests for my changes, if applicable.
  • This is required for all bug fixes and new features.
• I have updated the project documentation, if applicable.
  • This is required for new features.
• If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

• I have updated the project Changelog (this is required for all changes).
• I have verified that the pre-commit.ci checks have passed.
• I have verified that the CI tests have passed.
• I have reviewed the test coverage changes reported by Coveralls.
• I have requested a review from a project maintainer.

Questions and Comments

• We found this while working on TICKET-675: Scope LTI deployment lookups to the current course #8241.

[coveralls]

Coverage Report for CI Build 40715784452

Coverage increased (+0.006%) to 91.069%

Details

• Coverage increased (+0.006%) from the base build.
• Patch coverage: No coverable lines changed in this PR.
• No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

---

Coverage Stats

Relevant Lines:	54132
Covered Lines:	50345
Line Coverage:	93.0%
Relevant Branches:	2569
Covered Branches:	1292
Branch Coverage:	50.29%
Branches in Coverage %:	Yes
Coverage Strength:	127.28 hits per line

---

💛 - Coveralls