Skip to content

deps: bump actions to latest majors, Node to 24.x, and make deps/build releasable - #116

Open
shimoncohen wants to merge 11 commits into
masterfrom
deps/upgrade-actions
Open

shimoncohen wants to merge 11 commits into
masterfrom
deps/upgrade-actions

Conversation

@shimoncohen

@shimoncohen shimoncohen commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Bumps every third-party action on master to its latest release, plus the Node 20 defaults to 24.x (Node 20 is EOL):

  • checkout v7, setup-node v7, setup-python v7, github-script v9, release-please-action v5
  • create-pull-request v8, create-or-update-comment v5, find-comment v4, slash-command-dispatch v5
  • azure/setup-helm v5 (helm v3.22.1), kind-action v1.15.1, yq v4.54.1

I checked the breaking changes against usage, and none apply here:

  • setup-python v7 dropped pip-install
  • setup-node v6+ only auto-caches npm
  • create-pull-request v7 dropped PULL_REQUEST_NUMBER
  • github-script v9 no longer supports require('@actions/github')
  • checkout v7 blocks fork checkout in pull_request_target/workflow_run
  • everything else is the Node 24 runtime only (all jobs run on ubuntu-latest)

The action changes use one deps(<action>) commit per action, and release-please-config.json gets the changelog-sections the other MapColonies repos use, which make deps and build releasable. Without them only feat/fix/perf/revert count, which is why #114 never shipped. A release-please 17.6 dry run on this branch plans patch releases for helm-lint 1.1.1, update-artifacts-file 1.2.1, init-npm 1.2.1, validate-domain 1.0.1, update-chart-version 0.1.1 and smart-release-please 1.0.2. Merging moves their *-v1 tags.

actionlint: no new findings compared with master. update-artifacts-json fails because the helm-charts-test master ruleset (added 2026-09-02) rejects the test's direct push; this PR does not cause it.

Helm stays on v3: helm v4 is a major change for ct, so that is a separate decision.

🤖 Generated with Claude Code

shimoncohen and others added 8 commits October 18, 2026 12:57
… to v7, kind-action to v1.15.1

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…release-please-action to v5

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…to v8

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Without them only feat/fix/perf/revert are releasable, so deps and
build commits to an action never reach its tags. Sections match the
other MapColonies repos.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@shimoncohen shimoncohen changed the title deps: bump actions to latest majors and Node to 24.x deps: bump actions to latest majors, Node to 24.x, and make deps/build releasable Oct 18, 2026
@shimoncohen shimoncohen self-assigned this Oct 18, 2026

@ronenkapelian ronenkapelian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge order: this conflicts with #115 (helm-lint/action.yaml) and #118 (validate-domain/action.yaml). Please merge it after both, and drop deps(validate-domain) when rebasing, since #118 removes the yq step.

@ronenkapelian ronenkapelian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix CI error

helm-charts-test now redirects to helm-charts-new, whose default branch
requires pull requests, so the direct push to master is rejected (GH013).
The ci/update-artifacts-file-test branch is outside that ruleset.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@shimoncohen

Copy link
Copy Markdown
Contributor Author

CI fixed in f46141c: helm-charts-test now redirects to helm-charts-new, whose default branch requires PRs (GH013). The self-test now pushes to ci/update-artifacts-file-test (created there). run

@ronenkapelian ronenkapelian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEFAULT_NODE_VERSIONS is now 24.x in postgis-check-command.yml, but the README still says (default: 20.x). Callers use @master, so the docs go stale as soon as this merges.


[nitpick] The usage example still shows actions/checkout@v6. Everything else is now v7 and people copy this snippet, so maybe bump it too.

Comment thread .github/workflows/test-update-artifacts-file.yml
shimoncohen and others added 2 commits October 25, 2026 16:36
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@shimoncohen

Copy link
Copy Markdown
Contributor Author

README Node default now 24.x and smart-release-please example uses checkout@v7 (3789329).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants