Repository navigation
fix(security-management): honor zero-day issue-sync settings - #26
Draft
MakerFlyFly wants to merge 2 commits into
Draft
MakerFlyFly wants to merge 2 commits into
MakerFlyFly wants to merge 2 commits into
Conversation
Use the configured day count even when it is zero. Only missing or null values should use the disclosure-window, grace-period and reporter-timeout defaults; a zero grace period is explicitly documented by the template. Cover the CLI's zero values, defaults, numeric strings, positive values, calendar-day boundaries and label/message guards. Regenerate the packaged security-management source so plugin installations receive the same fix. Generated-by: Codex (gpt-6.1-sol)
Exercise all three issue-sync day settings through the CLI with empty strings, lists and objects, checking the JSON refusal and exit code 2 without depending on Python's exact conversion-error wording. Pin false-to-zero coercion with concrete disclosure dates and reporter staleness results. These compatibility cases retain the existing int() conversion policy and require no production-code changes. Generated-by: Codex (gpt-6.1-sol)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
window_days,grace_period_daysandtimeout_days; only missing or null values select the existing 90/14/14 defaults.2026-04-15to2026-04-01, while preserving the existing strict calendar-day expiry boundary and label/message guards.magpie-security-toolscopy so plugin installations receive the same repair.Type of change
tools/security-management) and its generated plugin sourceTest plan
prek run --all-files --skip workspace-pytestpasses, including the link checker, Ruff, formatting, mypy, plugin synchronization and eval-prompt validation.prek run workspace-pytest --from-ref origin/main --to-ref HEAD --verbosepasses: 114 + 758 = 872 tests across two applicable members.pre-first-pr-check: categories A–E pass; zero blocking or advisory categories.Validation used an isolated Linux checkout with Python 3.12.12 and the locked prek 0.5.6, invoked through
uv tool run --from prek==0.5.6 prek.RFC-AI-0004 compliance
Linked issues
Closes #25
Review follow-up
Review feedback was checked against
1fd48a4d; the follow-up commit is89951248.>, announcement labels and reporter-turn guards remain covered.The follow-up changes only the test file. It preserves the existing
int()conversion policy and avoids assertions on Python-version-specific error wording.Notes for reviewers
This Draft PR targets
MakerFlyFly/magpie:mainfor personal human audit. Its base is upstream30ee18c2a7d46a42ce94278beb197fa106e94763, fast-forwarded into the fork. The three changed files are the canonical helper, its CLI tests and the mandatory generated plugin copy.Negative-value validation and issue-import's separate positive-window policy remain outside this repair.
Generative AI disclosure
Codex (gpt-6.1-sol) generated the implementation, regression tests and this PR description, and ran the recorded checks. The contributor completed review and authorized the upstream submission. The upstream issue and PR are linked below.
Upstream submission
The contributor completed review and authorized upstream submission.
The upstream branch is based on
6fafad25and ends at59b5bd48. Both patches match the reviewed fork commits according togit range-diff. This fork entry is retained as the audit record.