Repository navigation
Fix madspace_tests failures on the lemaitre4 HIP runner - #296
Merged
Merged
Conversation
Co-authored-by: oliviermattelaer <33414646+oliviermattelaer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job learmaitre4 / madspace_tests
Fix madspace_tests failures on the lemaitre4 HIP runner
Oct 16, 2026
oliviermattelaer
marked this pull request as ready for review
October 16, 2026 22:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lemaitre4 / madspace_testsjob fails with 8 test failures on the HIP device. Two causes: tests convert GPU tensors withnp.asarray, and a tar test writes archives with an out-of-range uid. Both are test-side problems. I couldn't run the tests in my environment, so the fix still needs a run on the HIP runner.test_beam_frame.py(7 failures)np.asarrayon a GPU torch tensor goes through DLPack and raisesBufferError: Cannot export readonly array since signalling readonly is unsupported by DLPack.np.asarraycalls in this file now use theto_numpyhelper frommadspace_testing.py, which copies to the host first.to_numpynow wraps its argument intorch.as_tensor, so it also accepts plain numpy arrays.test_tar.py::test_read_tar_from_other_tool(1 failure)tarfileraisedValueError: overflow in number field, because the runner account's uid doesn't fit the GNU and USTAR header fields.tar.addnow takes ananonymousfilter that zeroesuid/gidand clearsuname/gname: