Repository navigation
Conversation
4 tasks done
MDA2AV
added a commit
that referenced
this pull request
Oct 14, 2026
… grep -q (#1564) Under `set -o pipefail`, `echo "$body" | grep -q PATTERN` fails whenever grep finds an early match and exits while echo is still writing: echo dies of SIGPIPE (exit 141) and the pipeline reports failure although grep matched. The fortunes checks hit this on a correct ~25 KB page, 769 of 2000 runs on the XSS check and 116 on the DOCTYPE check, and it showed up on #1548 as a false "<script> in row 11 not properly HTML-escaped". A here-string has no writer to kill: 0 of 2000. The other four places that pipe a captured variable into grep -q (the TLS resumption and close_notify probes, the json-tls Content-Type check) are switched too, so the rule is the same everywhere.
Docker only accepts lowercase image names, and validate.sh and benchmark.sh name the image httparena-<directory>. With the directory called aspnet-minimal-satoriGC, `docker run` rejected the name before any test ran; lowercasing the tag in build.sh only fixed the build step. display_name was "aspnet-minimal", the stock entry's name. Results are filed by display name, so a saved benchmark run would have overwritten aspnet-minimal's published numbers with this entry's.
Owner
|
/benchmark --save |
Contributor
|
👋 Benchmark request received. A collaborator will review and approve the run. |
Contributor
Benchmark ResultsFramework:
Full log |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.