Repository navigation
Update common to 0.7.0 and pass it a DebugTheme - #69
Merged
Merged
Conversation
The library's debug pages no longer use MaterialTheme; ProvideDebugSettings now takes a DebugTheme. ProvideAppDebugSettings maps the app's Material theme to one, and sits inside the app's theme. Also refreshes the lukeneedham-conventions skill. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FbwNMvEMdgfemec4rTEPEV
📲 AppHub |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the shared
commonlibrary from 0.6.0 to 0.7.0.In 0.7.0 the library's debug pages and
DebugButtonno longer useMaterialTheme;ProvideDebugSettingstakes aDebugTheme(colours + font family) instead.ProvideAppDebugSettingsmaps the app's (Material 2) theme to aDebugTheme.ProvideDebugSettingsmoved fromMainActivityintoRoot, insideVideoDiaryTheme, so it can read the theme. Nothing outsideVideoDiaryThemeinRootreads a debug setting.lukeneedham-conventionsskill to the latest fromLukeNeedham/ci-workflows.The library's pages are rebuilt without Material, so spacing and chip shapes differ slightly from before. Not run locally (no Android SDK here); the CI build is the first compile.
Generated by Claude Code