Repository navigation
Video storage location: crash-safe migration (builds on #54) - #68
Open
LukeNeedham wants to merge 11 commits into
Open
LukeNeedham wants to merge 11 commits into
LukeNeedham wants to merge 11 commits into
Conversation
- Copy videos via VideoFolderTransfer: sources are only deleted after every copy is verified, and failures roll back cleanly (no leftover temp files, no partial moves) - Save the storage setting inside the move and keep running if the caller is cancelled, so files and setting can't disagree - Fall back to internal storage when the SD card is missing, warn in the UI, and merge videos back when it returns - Re-check SD card availability when the storage screen opens - Guard file changes with a lock and detect diary changes during a move - Add unit tests; tidy Koin import and progress indicator size Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FBqFYw2zBG9C9sT7ABYdMN
Uses the same header, uppercase section label, rounded AppSurface card with icon-box rows and dividers, accent-tinted notices, and radio buttons coloured like the Debug switches. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FBqFYw2zBG9C9sT7ABYdMN
Resolves conflicts in VideosDao (shared common Logger) and NormalRouter. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FBqFYw2zBG9C9sT7ABYdMN
The Debug page gets a Storage section: a fake SD card (a folder in the app's files), a switch to insert/remove it, and an 8 second pause during video moves, so Video storage can be tested without a real SD card. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FBqFYw2zBG9C9sT7ABYdMN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds on #54 (SD card / internal storage setting, closes #1) and fixes the problems found in review. This branch contains #54's commits plus one fix commit, so it can replace #54.
VideosDao.moveVideosTo, which keeps running if the caller is cancelled. Files and setting can no longer disagree.VideoFolderTransfercopies via temp files, verifies sizes, only deletes sources after everything is copied, and rolls back cleanly. Stale.movingfiles are cleaned up, so a failed attempt no longer blocks retries.videosDiris@Volatile, and a move fails safely if the diary changed during the copy.VideoFolderTransferTestcovers commit, rollback, conflicts, stale temp files and change detection.Notes
mainhas moved on (sharedcommonlibrary logger); this branch is still based on Feature/change storage path #54, so it will need a merge frommainbefore it can land. Not done here.:app:testDebugUnitTest, passing). The SD card flow itself was not tried on a device or emulator.Generated by Claude Code