Skip to content

Give the user-step boot test room on a loaded runner - #160

Merged
LucaCappelletti94 merged 1 commit into
mainfrom
fix/boot-deadline-slack
Oct 15, 2026
Merged

LucaCappelletti94 merged 1 commit into
mainfrom
fix/boot-deadline-slack

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Owner

workers::tests::a_boot_waiting_on_the_user_is_not_timed_out failed on #140's browser shard (https://github.com/LucaCappelletti94/connetto-rs/actions/runs/38732376739) with Timeout { deadline_ms: 500.0 } and passed on rerun. Its messages arrive 400 ms apart against a 500 ms deadline, so a slow runner had 100 ms to spare before the first one.

The deadline is now 1000 ms. The ready message still lands at about 1200 ms, past a deadline counted from the start, so the test still fails if the user step stops pausing the clock, and a delayed message only lands later. Each message now has 600 ms of slack.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 12 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: LucaCappelletti94/coderabbit/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 8b70c243-ae29-406d-b2a2-ae928edf8e25
📥 Commits

Reviewing files that changed from the base of the PR and between b1555fa and 3c33d90.

📒 Files selected for processing: 1
  • crates/connetto-web/src/workers/tests.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.50%. Comparing base (b1555fa) to head (3c33d90).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
+ Coverage   87.48%   87.50%   +0.02%     
==========================================
  Files         186      186              
  Lines       48991    48991              
  Branches    48991    48991              
==========================================
+ Hits        42860    42870      +10     
+ Misses       4072     4064       -8     
+ Partials     2059     2057       -2     
Flag Coverage Δ
client 59.65% <ø> (-0.02%) ⬇️
rest 55.43% <ø> (+0.22%) ⬆️
server 52.04% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud

Copy link
Copy Markdown

@LucaCappelletti94
LucaCappelletti94 merged commit 8f6d399 into main Oct 15, 2026
57 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant