Repository navigation
Give the user-step boot test room on a loaded runner - #160
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 12 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #160 +/- ##
==========================================
+ Coverage 87.48% 87.50% +0.02%
==========================================
Files 186 186
Lines 48991 48991
Branches 48991 48991
==========================================
+ Hits 42860 42870 +10
+ Misses 4072 4064 -8
+ Partials 2059 2057 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|



workers::tests::a_boot_waiting_on_the_user_is_not_timed_outfailed on #140's browser shard (https://github.com/LucaCappelletti94/connetto-rs/actions/runs/38732376739) withTimeout { deadline_ms: 500.0 }and passed on rerun. Its messages arrive 400 ms apart against a 500 ms deadline, so a slow runner had 100 ms to spare before the first one.The deadline is now 1000 ms. The ready message still lands at about 1200 ms, past a deadline counted from the start, so the test still fails if the user step stops pausing the clock, and a delayed message only lands later. Each message now has 600 ms of slack.