Repository navigation
fix(roles/nextcloud): enable the support app and hide its admin section again - #459
Merged
Merged
Conversation
…on again The role disabled the `support` app, which Nextcloud ships enabled. That app renews the subscription record of an Enterprise instance every 23 hours. Disabled, the record froze at its last answer, and nextcloud-enterprise warns about it on every Enterprise host deployed with LFOps. Without a subscription key the app contacts nobody, so community instances are not affected. `support hide-app` has been stored as boolean `1` since the switch to the `nextcloud_occ_app_config` module (#202). The app hides its admin section only on `getAppValue('support', 'hide-app', 'no') === 'yes'`, so the section was visible again. The value is the string `yes` now; the module converts the stored type with `--no-interaction`. Verified in the source of `support` 7.0.0 and `core/shipped.json` of Nextcloud 35.0.2.
…g yes
The dav post-migration repair step BuildCalendarSearchIndex skips itself
only on `getAppValue('dav', 'buildCalendarSearchIndex') === 'yes'`. Since
#202 the role stores boolean `1`, so on every upgrade the step queues a
full rebuild of the calendar search index and then writes `yes` back with
`setAppValue()`, which AppConfig rejects with AppConfigTypeConflictException
(mixed over boolean). Repair::run() catches and logs it as an error, so the
upgrade itself goes through.
Verified in the Nextcloud server source (master of 2026-09-18).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
supportapp by default, as Nextcloud ships it (core/shipped.json,defaultEnabled). It renews the subscription record of an Enterprise instance every 23 hours. Disabled, the record freezes, andnextcloud-enterprisefrom the Monitoring Plugins warns about stale subscription data on every Enterprise host deployed with LFOps. Without a subscription key the app makes no outbound request.support hide-appto the string'yes'again. Since Feature/nextcloud modules #202 it has been stored as boolean1, but the app only hides its admin section ongetAppValue('support', 'hide-app', 'no') === 'yes'.dav buildCalendarSearchIndexas the string'yes'again. The dav post-migration repair step skips itself only on=== 'yes'. With the boolean1stored since Feature/nextcloud modules #202, every Nextcloud upgrade queues a full rebuild of the calendar search index, and the step then fails withAppConfigTypeConflictExceptionwhen it writesyesback.Repair::run()logs that as an error and continues.extensions/molecule/setup_nextcloud/verify.yml.Verified in the source of
support7.0.0 andcore/shipped.jsonfrom the Nextcloud 35.0.2 release tarball.Test plan
molecule test --scenario-name setup_nextcloud