Repository navigation
hostmot2: harden Smart Serial and absolute encoder handling - #4662
sleepybishop wants to merge 10 commits into
Conversation
|
Same comment on the test as in #4660. |
|
This needs to be thoroughly tested on real hardware that uses the changed code-paths. |
|
@rene-dev when you get to the test the three branches from @hdiethelm maybe you could give a check at this as well? |
| chan->confs = (hm2_sserial_data_t *)rtapi_krealloc(chan->confs, | ||
| chan->num_confs * sizeof(hm2_sserial_data_t), | ||
|
|
||
| if (q > RTAPI_UINT8_MAX) { |
There was a problem hiding this comment.
What guards q from being negative?
There was a problem hiding this comment.
Added q < 0 and kept q as long until validation.
| hal_set_ui32(inst->fault_count, | ||
| fault_count + hal_get_ui32(inst->fault_inc)); |
There was a problem hiding this comment.
Why just the line break? Terminals have been wider than 80 for the past 30 years or so?
(other places too)
There was a problem hiding this comment.
Removed the added wrapping. The remaining fault-count edits remove unused assignments.
| @@ -0,0 +1,25 @@ | |||
| HostMot2 Smart Serial software regression tests | |||
There was a problem hiding this comment.
Same comment on the test as the pktuart test.
|
Thank you, I removed the standalone harness. |
Split from #4488 as requested. Adds Smart Serial/absolute-encoder parsing, allocation and cleanup checks, validates flash geometry, and fixes floating-point parameter comparisons, including unchanged NaNs. Setup-mode state-machine changes remain excluded.
Local builds pass. Hardware testing remains pending.