Repository navigation
chore: pin LML at its Mathlib bump and build main with --iofail - #109
Merged
Merged
Conversation
Since the rc2 sync, LMLExplore builds LML against Tau Ceti's Mathlib, which deprecates lemmas LML used. The warnings in LML's modules fail the sandboxed PR build, which runs `lake build --iofail`, so every PR was red, while main's plain `lake build` stayed green. LML #290 bumps LML's Mathlib to the commit of Tau Ceti's v4.36.0-rc2 tag, the one LMLExplore pins, and adopts the new names. Pin LML at that merge (efbe5d2). Build main with `--iofail` too, so that main fails whenever PR builds do. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lmlexplore-automation
Bot
added
the
ci-failed
lmlexplore-automation
Bot
removed
the
ci-failed
RemyDegenne
added a commit
that referenced
this pull request
Nov 3, 2026
Merge main (#109 re-pins LML, fixing the --iofail deprecation-warning failures in LML ForMathlib modules). The new TauCeti pin provides ProbabilityTheory.expMeasure_of_nonpos, which the simpNF lint flagged as duplicating LMLExplore.expMeasure_of_nonpos; delete the local copy and use the upstream lemma. Co-Authored-By: Claude Code <noreply@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every open PR (#105, #106, #108) fails the sandboxed build, for a reason outside their code. Since the rc2 sync (#107), LMLExplore builds LML against Tau Ceti's Mathlib, which is 158 commits newer than LML's own pin and deprecates
Measure.coe_addandMeasure.smul_apply. Five LML modules then log deprecation warnings, and the PR build'slake build --iofailfails on them. Main's plainlake buildshowed the same five warnings but stayed green.Changes:
61cd177→efbe5d2, the merge of Bump Mathlib to the commit of Tau Ceti's v4.36.0-rc2 tag LML#290. That PR bumps LML's Mathlib to1b1ccf4, the commit that Tau Ceti'sv4.36.0-rc2tag pins and that LMLExplore already requires, and adopts the new names. Every other entry of LML's manifest now equals LMLExplore's..github/workflows/ci.ymlrunslake build --iofail, as the sandboxed PR build does, so main goes red whenever PR builds would.Checked locally on this branch:
scripts/build.sh --iofail(7314 jobs, no warnings),lake exe axioms(2471 declarations, all within the allowlist),lake exe module-system(all 146 modules). The environment lint was not re-run: no LMLExplore declaration and no Mathlib file changed.This PR changes a pin and
.github/, sobump-guardand the sandboxed build cannot pass on it (as for #107): it needs an admin merge. Note thatci.ymlis rendered from TauCetiTools' project template, which still sayslake build; a latertauceti-tools doctor --fix workflowswould revert the second change unless the template is updated.After the merge, the open PRs need their CI re-run.
Roadmap: none
🤖 Generated with Claude Code