ci: install libdbus-1-dev for the nightly Tracy capture's tool build - #869
Merged
Merged
Conversation
tracy-capture's build pulls in nfd, whose CMake requires dbus-1 through pkg-config; the ubuntu-24.04 runner lacks it, so the job stopped at "The following required packages were not found: - dbus-1" before capturing anything. Tracy's other optional libraries fall back to its own fetched copies and are left alone. Closes #868 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #868.
The first scheduled run of the nightly
tracy-capturejob (added in #861) failed in "Build tracy-capture and tracy-csvexport", before anything was captured:tracy-capturepulls in nfd (native file dialog), which requiresdbus-1through pkg-config. This PR installspkg-configandlibdbus-1-devin that job's install step. capstone, freetype2 and bzip2 were reported missing too, but they are optional: Tracy falls back to its own fetched, pinned copies, so they are left alone.Verification:
actionlintis clean. This PR's own CI does not exercise the nightly job. The real check is the next scheduled run after merge. Itsreconcile-issuesjob closes #868 automatically on a pass, and re-opens it on a fail. I did not trigger the workflow by hand, because a manual run also runsreconcile-issues, which files and closes issues.What would change this: if the next run fails at a later step (configure, build, or either capture), that is a new finding about the job, and #868 stays open with that run's output.
🤖 Generated with Claude Code