Repository navigation
Fixes --enrich crashes caused by unexpected API responses and non-string identifier values - #1129
Merged
Merged
Conversation
…ptureAndDiscovery/dev Dev
…ptureAndDiscovery/dev Small fix for reference publication title extraction
…ptureAndDiscovery/dev Update master with changes for 0.11.4.
…ptureAndDiscovery/dev update codemeta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enrich fixes
Fixes
--enrichcrashes caused by unexpected API responses and non-string identifier values.Issue
#1126
Summary
The original error happened because OpenAIRE could return
response: null, making chained.get()calls fail_safe_json_response()to safely parse API JSON and ignore invalid/non-dict responsesNoneinstead of crashing_extract_doi_from_value()to extract DOIs from strings, dicts, or lists preventingre.search()from receiving lists when metadata identifiers are structuredThe enrichment flow now falls back cleanly when external services or metadata shapes are incomplete