Repository navigation
[#612] Keep check-in QR codes valid across reloads - #613
DVidal1205 wants to merge 2 commits into
Conversation
Co-authored-by: Codex <codex@openai.com>
📝 WalkthroughWalkthroughThe dashboard now uses a fixed idempotency key when requesting check-in passes. Check-in lookup can resolve a revoked token when another unexpired active pass exists for the attendee. Withdrawal revokes active passes and deletes matching issuance commands. Tests cover token resolution, expiration, and command cleanup. Priority: ⬆️ High Severity of issue fixed: Medium Merge Risk: 🟡 Moderate · up to Check-in QR codes now stay valid across reloads. However, a QR code invalidated by withdrawal may start working again if the attendee reconfirms. This conflicts with the stated withdrawal-invalidation guarantee and should be resolved or explicitly accepted before merge. Pre-merge checks |
|
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository: KnightHacks/forge/.coderabbit.yml
- Review profile: QUIET
- Plan: Advanced
- Run ID:
e7b685bb-1658-435e-8f18-3307e20e38f5
📒 Files selected for processing (5)
apps/2026/src/lib/hacker-portal.tsxpackages/api/src/hacker-portal/mutations.tspackages/api/src/tests/hackathon-events/check-in.test.tspackages/api/src/tests/integration/hacker-portal-lifecycle.test.tspackages/api/src/utils/hackathon-events/check-in.ts
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
Co-authored-by: Codex <codex@openai.com>
CodeRabbit confirmed the finding was addressed in 2882aa4 and resolved the review thread.
Why
Reloading or reopening the 2026 dashboard issued a new check-in pass and revoked the previous pass. Screenshots then appeared as
invalid_qrin Blade, leaving the operator without a resolved name, date of birth, or class during peak admission.Closes: #612
What
user:QR handlingNo schema, environment variable, or dependency changes.
Test Plan
pnpm verify:precommitpackages/api/src/tests/hackathon-events/check-in.test.ts(15/15 passed)Screenshots are not applicable because this changes QR issuance and scanner validation without changing UI.
Checklist
pnpm db:generateand committed the generated files inpackages/db/drizzle/