Skip to content

Swap chain: point extension support check to physical device selection - #550

Merged
marty-johnson59 merged 1 commit into
KhronosGroup:mainfrom
stradoc:swapchain-support-text
Nov 16, 2026
Merged

marty-johnson59 merged 1 commit into
KhronosGroup:mainfrom
stradoc:swapchain-support-text

Conversation

@stradoc

@stradoc stradoc commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

Follow up to PR #493 (which fixed #304), by cleaning up the duplicate device-creation text in this section.

The original PR left a paragraph mentioning extending the createLogicalDevice function, which is incorrect, as we already queried for requiredDeviceExtension in isDeviceSuitable during physical device selection. So it was removed and replaced with a sentence pointing back to the physical device selection section.

I also removed the "First declare a list of required device extensions" step and its code block, because requiredDeviceExtension was already covered in earlier chapters. I kept the note about vk::KHRSwapchainExtensionName catching misspellings.

This also matches Vulkan-Tutorial/attachments/06_swap_chain_creation.cpp which does not check for the swapchain extension in createLogicalDevice.

@marty-johnson59
marty-johnson59 merged commit f89d642 into KhronosGroup:main Nov 16, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Device Extensions Feedback

2 participants