Repository navigation
Swap chain: point extension support check to physical device selection - #550
Merged
marty-johnson59 merged 1 commit intoNov 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to PR #493 (which fixed #304), by cleaning up the duplicate device-creation text in this section.
The original PR left a paragraph mentioning extending the
createLogicalDevicefunction, which is incorrect, as we already queried forrequiredDeviceExtensioninisDeviceSuitableduring physical device selection. So it was removed and replaced with a sentence pointing back to the physical device selection section.I also removed the "First declare a list of required device extensions" step and its code block, because
requiredDeviceExtensionwas already covered in earlier chapters. I kept the note aboutvk::KHRSwapchainExtensionNamecatching misspellings.This also matches
Vulkan-Tutorial/attachments/06_swap_chain_creation.cppwhich does not check for the swapchain extension increateLogicalDevice.