Repository navigation
Logical device chapter: remove unused PhysicalDeviceFeatures section and fix structure count - #548
Merged
marty-johnson59 merged 1 commit intoNov 16, 2026
Conversation
…tion, fix: the structure count from three to four
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logical device chapter in
03_Drawing_a_triangle/00_Setup/04_Logical_device_and_queues.adochad an old section called "Specifying used device features", which had a line of code:vk::PhysicalDeviceFeatures deviceFeatures;. It was unused, because in the next section you enable device features using a structure chain, and it doesn't appear in04_logical_device.cppfile, so it was removed.Also, in the same chapter it mentioned a struct having "three different feature structures" when in reality it had four, so I fixed that as well.