Repository navigation
Conversation
Break the framework -> plugins -> apps -> samples -> framework cycle, which put every sample's include directories on every compile command, and add a shared precompiled header (VKB_USE_PCH, default ON) reused by the framework, samples, apps and plugins.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduces build times by breaking the dependency cycle between the
framework, plugins, apps and samples, and by adding a shared
precompiled header.
Changes
AppInfo/SampleInfomove toframework/platform/app_info.h.getSamples()moves toapp/android/sample_list_jni.cpp.appslinks samples PRIVATE;pluginsuses normal target links.VKB_USE_PCH, default ON)framework/common/pch.h, owned by the framework and reused bysamples, apps and plugins.
*_IMPLEMENTATIONmacros opt out.Measurements
Linux, clang, 24 threads, ccache off, shaders off, full rebuild:
Median
-Iflags per TU: 247 -> 9. Windows is not measured.