Repository navigation
Conversation
Contributor
does problemtools detect MLE at all? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setting up rules for submissions, it's impossible to express other verdicts than AC, RTE, TLE, WA. After discussions in Kattis/problem-package-format#616 it's clear to me that the intent was for other statuses to be remapped to those. This PR does that.
This also gets backported for legacy - now an MLE is fine in the
run_time_errordirectory (and OLE inwrong_answer). I think the sole reason people have not complained about this earlier is that problemtools currently is pretty bad at detecting MLE:s. :)Bonus: fixes the type annotation of
SubmissionResult.verdictto be aVerdict.