Repository navigation
Extract testcase model - #472
Merged
Merged
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
pehrsoderman
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors
TestCaseandTestCaseGroupfrom verifyproblem into models + checks. In the model, I renamed the latter toTestDataGroupsas that seems to be the naming in the problem format now.Note that this implementation is pretty closely tied to legacy (as was the code in verifyproblem). Rules and properties have changed quite significantly in the new version, and I did not add plumbing for that in this PR.
Checks were kept as close as possible. This means (temporarily) exposing the constants
DEFAULT_CONFIGandSCORING_ONLY_KEYSfrom model.The check for out-of-bounds score in a group was moved to submission checks (as we only discover that by running submissions).
Progress on #398 (verifyproblem.py is now < 1000 lines! :)