Repository navigation
Conversation
Contributor
|
Thanks for giving a heads-up about the bug fix. We do not pin dependencies (yet). What's in the file is a lower bound. I don't think we want to bump the lower bound for corner case bug fixes, so closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug introduced in one of the previous versions. Under the right cicumstances this could lead to float and integer constant getting mixed up which in turn could make division results wrong (float and integer division behave different).
This is now fixed but I would recommend to bump the version here so people do not get unexpected results?