Repository navigation
docs(appevents): correct the Android activation behaviour in the parity notes - #8
Merged
Merged
Conversation
…ty notes The iOS behaviour was right: with SDK 18.0.2, AppEvents.activateApp logs fb_mobile_activate_app through the public logEvent path as an explicit event, whatever isAutoLogAppEventsEnabled says. The Android comparison was wrong: facebook-core 19.0.0 drops activation events while automatic logging is off, so ActivateApp() sends only the install ping, and turning the flag off stops activations at once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I checked whether
ActivateApp()logsfb_mobile_activate_appwhen automatic logging is off in the bundled Meta iOS SDK 18.0.2, using thefacebook/facebook-ios-sdksources at tagv18.0.2(32da5bd). It does, so the iOS docs and XML docs are correct and unchanged:FBSDKAppEvents activateAppcallspublishInstall, thenfetchServerConfiguration, then[timeSpentRecorder restore:YES].FBSDKTimeSpentData(wired toAppEvents.sharedinCoreKitComponents.swift) calls[eventLogger logEvent:FBSDKAppEventNameActivatedApp parameters:...]. The parameters carry no_implicitlyLoggedkey, so the event is explicit.logInternalEventchecksisAutoLogAppEventsEnabled, and the flush only includes implicit events whenimplicitLoggingEnabled && isAutoLogAppEventsEnabled. Explicit events are not gated on that flag.ApplicationDelegate) only callsactivateAppwhenisAutoLogAppEventsEnabledis true.The only error was in the section 4.8 parity notes, which described the Android package's behaviour. facebook-core 19.0.0 logs activations through
InternalAppEventsLogger.logEvent, which returns early while automatic logging is off. As a result:ActivateApp()there sends only the install ping;This PR corrects those notes. Companion PR: Kapusch/FacebookApisForAndroidComponents#7.
🤖 Generated with Claude Code