Repository navigation
Test that kernels don't contain invalid integer widths - #715
Merged
Merged
Conversation
maleadt
added
kernels
maleadt
marked this pull request as ready for review
October 25, 2026 13:29
maleadt
force-pushed
the
tb/native-int-widths
branch
from
October 25, 2026 13:29
66e7144 to
8a8d4c3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #715 +/- ##
==========================================
- Coverage 86.84% 86.39% -0.45%
==========================================
Files 56 55 -1
Lines 5123 4983 -140
==========================================
- Hits 4449 4305 -144
- Misses 674 678 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression test for #172, which GPUCompiler fixes in JuliaGPU/GPUCompiler.jl#1027. GPUCompiler's SPIR-V datalayout declared no native integer widths, so InstCombine narrowed values to widths like
i2(aswitchonx & 3) ori63(complexx^x). The Khronos translator, used underONEAPI_LTS, segfaults on those. With the fix, these kernels compile on both back-ends, so this also stops skipping complexx^xunder LTS.Draft until GPUCompiler 2.15.2 is released; the compat bump requires it.
Fixes #172.