Preserve embedded NUL bytes in text values - #366
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading a TEXT value such as
"abc\0xyz"currently returns"abc". Julia scalar and aggregate SQL functions also receive the shortened argument, even though SQLite retains all seven bytes.Read the UTF-8 pointer and its byte count in both text readers so the resulting Julia string contains the complete value. This follows SQLite's documented column extraction order and value extraction contract. SQLite permits embedded NUL characters in stored text.
Validation:
hex(value)controls confirm that SQLite retains the full bytes.--trim=safeon Julia 1.13.1 and exits successfully withJULIA_LOAD_CODEGEN_LIB=0and runtime Unicode input.This change was researched, implemented, and tested by Codex as part of an AI-driven maintenance review.
Co-authored by Codex