added: unit="s" keyword argument in all SimModel constructors - #462
Merged
Merged
Conversation
It modifies the suffix of the x-axis label in the plot (no underlying time data conversion), and also the unit of time shown when pretty-printing objects. This is not strictly necessary for plots since we can modify the x-axis label after a is generated, but we still needs to this on all the generated plots, thus simplifying the API in the end.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #462 +/- ##
==========================================
+ Coverage 97.17% 97.22% +0.04%
==========================================
Files 28 28
Lines 6867 6874 +7
==========================================
+ Hits 6673 6683 +10
+ Misses 194 191 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It modifies the suffix of the x-axis label in the plots (no underlying time data conversion), and also the unit of time shown when pretty-printing objects.
This is not strictly necessary for plots since we can modify the x-axis label after a plot is generated, but we still needs to this on all the generated plots, thus simplifying the API in the end.