Repository navigation
Conversation
c-dilks
requested review from
baltzell,
hauenst,
raffaelladevita,
tongtongcao and
zieglerv
as code owners
October 12, 2026 19:23
baltzell
removed their request for review
October 12, 2026 21:48
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are only using its
LineFitter,LineFitPars, andProbChi2perNDF.Here is a repository showing the decompiled JAR file (you must be signed in): https://code.jlab.org/dilks/jarchaeology-trackfitter
LineFitter&LineFitParsThese classes are only consumed by the
reconstruction/dcmodule, which has its own versions of these classes already.The decompiled
trackfitterversion is practically the same as ourdcmodule's version; however,trackfitter'sLineFitter.fitStatusmethod hasdouble[]parameters, whereas ourdcmodule's version hasList<double>parameters, and both of these signatures are in use in practice in thedc. I'm not sure which one is actually called more often at runtime, but thedouble[]version is more commonly written in the source code calls.I changed the
dcmodule'sLineFitter.fitStatusmethod to takedouble[]parameters, rather thanList<double>parameters, and added an overload that takesList<double>parameters; this is more efficient than overloading the other way around since it avoids boxing in any hot loop.ProbChi2perNDFThis class does not appear to be implemented anywhere in
coatjava. I rewrote the decompiled version of this function usingapache'scommon-math3in a new local class with the same name, and put it in thecommon-tools/clas-trackingmodule. The edge-case handling remains the same, and is actually consistent with ROOT'sTMath::Probfunction.For comparison, see the decompiled
ProbChi2perNDF, which depends onErrorFunctionandGammaFunction(also withintrackfitter).Additional Changes
I also removed dead code and resolved some warnings; unused code that seems non-trivial is commented out, rather than removed.