feat(views): inline rename in the embedded viewer; View/share copy - #456
Open
allison-truhlar wants to merge 8 commits into
Open
allison-truhlar wants to merge 8 commits into
allison-truhlar wants to merge 8 commits into
Conversation
allison-truhlar
added this pull request to stack #429
September 22, 2026 17:57
allison-truhlar
force-pushed
the
ngviews-10-viewer-polish
branch
from
September 22, 2026 20:06
7040e0e to
57a5093
Compare
allison-truhlar
marked this pull request as ready for review
September 23, 2026 14:06
…opies the View link - viewQueries: useUpdateViewMutation invalidates the state query only when ng_state changes, so a name-only rename doesn't reload the embedded Neuroglancer iframe. - ngViewsColumns: "Copy View link to share" now copies the short /view/:read_key link instead of the external Neuroglancer URL; removed the now-unused baseUrl plumbing through NGViews/useNGViewsColumns/ActionsCell. - NeuroglancerView: reuse ViewsContext's allViewsQuery instead of calling useViewsQuery() directly. - NeuroglancerView: InlineNameEditor breadcrumb className matches the read-only branch's inherited color. - InlineNameEditor: Cancel button is disabled while a save is in flight.
The prior fix narrowed useUpdateViewMutation's invalidation from the broad ['views'] prefix to just the list key, which stopped covering viewQueryKeys.forDataLink(sharingKey). AppearsInViews and the Data Link delete dialog's dependentViewsQuery read view.name from that cache, so a rename left them showing the stale name. Add forDataLinkAll() and unconditionally invalidate it alongside the list key; the state-key invalidation stays conditional on ng_state changing.
allison-truhlar
force-pushed
the
ngviews-10-viewer-polish
branch
from
September 29, 2026 19:21
e95ab0e to
ec3271f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dev-feedback branch 10 (items 10, 12, 13 of the 3.3.0a0 test-release feedback). Spec:
docs/superpowers/specs/2026-09-16-ngviews-dev-feedback-design.md.What changed
InlineNameEditoris extracted from the jobs pageJobTitleEditorand reused; the viewer finds its own View (ownership, name,short_key) by matchingread_keyin the cached owner Views list. Non-owned Views show a read-only title./view/<read_key>link instead of the external Neuroglancer URL.['views']prefix), so the Neuroglancer iframe no longer reloads on rename. The per-Data-Link "Appears in N Views" lists refresh too.Testing
Frontend suite green, prettier and eslint clean,
node-checkat the known baseline. Playwright suite not run for this branch.