Repository navigation
Only copy include files (compiler, module choice) that are used - #2163
Merged
climbfuji merged 1 commit intoOct 14, 2026
Merged
Conversation
…ude files (compiler, module choice) that is being used
AlexanderRichert-NOAA
approved these changes
Oct 14, 2026
AlexanderRichert-NOAA
left a comment
Collaborator
There was a problem hiding this comment.
FWIW I could see it being useful to also have a flag for copying other files/directories to support misc. site-specific stuff, but that can be added later. This is definitely a positive change.
mathomp4
approved these changes
Oct 14, 2026
Collaborator
Author
|
I'll merge this after #2140 without rerunning the tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update spack-ext/lib/spack-stack/stack/stack_env.py to only copy the include files (compiler, module choice) that are used from the common/site config directories to the environment's common/site directories.
This PR is optional. If folks prefer to copy everything, that's fine with me. I find it less confusing to not have yaml config files in the environment common/site directories that aren't used.
Dependencies
None
Issues addressed
Closes #2069
Applications affected
None
Systems affected
None
Testing
spack stack create env ...and verified that only the files are copied that are used by the environmentChecklist
All dependency PRs/issues have been resolved and this PR can be merged.All necessary updates to the documentation (spack-stack wiki) will be made when this PR is merged