Skip to content

Only copy include files (compiler, module choice) that are used - #2163

Merged
climbfuji merged 1 commit into
JCSDA:developfrom
climbfuji:feature/copy_only_used_includes
Oct 14, 2026
Merged

climbfuji merged 1 commit into
JCSDA:developfrom
climbfuji:feature/copy_only_used_includes

Conversation

@climbfuji

@climbfuji climbfuji commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Update spack-ext/lib/spack-stack/stack/stack_env.py to only copy the include files (compiler, module choice) that are used from the common/site config directories to the environment's common/site directories.

This PR is optional. If folks prefer to copy everything, that's fine with me. I find it less confusing to not have yaml config files in the environment common/site directories that aren't used.

Dependencies

None

Issues addressed

Closes #2069

Applications affected

None

Systems affected

None

Testing

  • CI: Note whether the automatic tests (GitHub actions tests that run automatically for every commit) pass or not
    • GitHub actions CI tests pass
    • GitHub actions CI tests do not pass (provide explanation)
    • GitHub actions CI tests skipped (provide explanation if necessary)
  • New tests added: List and describe any new tests added to GitHub actions
    • ...
  • Additional testing: Add information on any additional tests conducted
    • Tested spack stack create env ... and verified that only the files are copied that are used by the environment

Checklist

  • This PR addresses one issue/problem/enhancement or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.
  • All necessary updates to the documentation (spack-stack wiki) will be made when this PR is merged

…ude files (compiler, module choice) that is being used

@AlexanderRichert-NOAA AlexanderRichert-NOAA left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I could see it being useful to also have a flag for copying other files/directories to support misc. site-specific stuff, but that can be added later. This is definitely a positive change.

@climbfuji

Copy link
Copy Markdown
Collaborator Author

I'll merge this after #2140 without rerunning the tests.

@climbfuji
climbfuji merged commit 5d97fc0 into JCSDA:develop Oct 14, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in spack-stack-2.2.x (2026 Q?) Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Copy only site-include packages_*yaml that are used

3 participants