Skip to content

fix: skip setRead when the in-app message is no longer queued #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joaodordio merged 2 commits into from
Oct 8, 2026
Merged

fix: skip setRead when the in-app message is no longer queued #916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fd841c
fix: skip setRead when the in-app message is no longer queued
jena-chakour Oct 6, 2026
e49a57a
docs: add the 3.2.1 changelog for the Android setRead crash fix
jena-chakour Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
## 3.2.1

### Fixes

- Fixed an Android crash when marking an in-app message as read after that message was no longer in the native queue.
- `setReadForMessage` logs and returns when the message id is missing, matching the iOS bridge. The Android bridge was passing that missing message into `IterableInAppManager.setRead`, which threw a `NullPointerException` and killed the app process.

## 3.2.0

### Updates
Expand Down
9 changes: 8 additions & 1 deletion android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,14 @@ public void execute(@Nullable Uri url) {

public void setReadForMessage(String messageId, boolean read) {
IterableLogger.v(TAG, "setReadForMessage");
IterableApi.getInstance().getInAppManager().setRead(RNIterableInternal.getMessageById(messageId), read);
IterableInAppMessage message = RNIterableInternal.getMessageById(messageId);

if (message == null) {
IterableLogger.d(TAG, "Failed to get in-app for message ID: " + messageId);
return;
}

IterableApi.getInstance().getInAppManager().setRead(message, read);
}

public void removeMessage(String messageId, double location, double deleteSource) {
Expand Down
Loading