Repository navigation
Serve push notification test image from MockWebServer - #1097
Open
franco-zalamena-iterable wants to merge 2 commits into
Open
franco-zalamena-iterable wants to merge 2 commits into
franco-zalamena-iterable wants to merge 2 commits into
Conversation
testNotificationImage pointed attachment-url at a live logo on assets.iterable.com. That asset now returns 404, so getInputStream() throws, no BigPictureStyle is attached, and the EXTRA_PICTURE assertion fails on every branch including master. Serve the existing 350x150.png test resource locally instead so the test no longer depends on a CDN. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
IterableRequestTask resolves the endpoint from a static override on every attempt and schedules retries on a static main-looper Handler up to RETRY_DELAY_MS * MAX_RETRY_COUNT ahead. testResponseCode500 asserted that retry #2 happened and returned, leaving retries 3-5 pending; those fired after tearDown and re-resolved to the next test's MockWebServer, consuming the response it had enqueued. The default queue dispatcher blocks on an empty queue, so the victim hung until its latch timed out - usually testResponseCode400WithoutMessage - and a stray response reaching a finished test's assertion in a callback crashed the instrumentation process. Serve responses from a dispatcher that repeats the last scripted response so a stray request is harmless, and end the 500 retry chain with a success so it cannot outlive the test. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing test failing on CI
No customer facing changes